Fix UNC paths #110033
Open
Fix UNC paths #110033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
Open
3 tasks
If the input file was a network path then the raw path returned by GetFinalPathByHandle may return a UNC path. If so, and if the original path wasn't a UNC path, and the original path doesn't need normalization, we want to use the original path.
agocke
force-pushed
the
fix-unc-paths
branch
from
dd27740 to
1042720
Compare
This was referenced Nov 26, 2024
elinor-fung
reviewed
Dec 3, 2024
This was referenced Dec 7, 2024
elinor-fung
reviewed
Dec 7, 2024
Co-authored-by: Elinor Fung <[email protected]>
3 tasks
|
Finished testing this around MAX_PATH. It has the expected behavior, as far as I can see. In particular, if you have a path that is very close to MAX_PATH, and the resultant UNC extended path exceeds MAX_PATH, the result will be a UNC path. I think that's fine, and it makes the code simpler to not deal with chopping off the extra UNC extended bytes. |
Co-authored-by: Elinor Fung <[email protected]>
3 tasks
elinor-fung
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the input file was a network path then the raw path returned by GetFinalPathByHandle may return a UNC path. If so, and if the original path wasn't a UNC path, we want to remove the UNC prefix unless it was necessary to fully resolve the path.