-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak Invariant IndexOf logic #108709
Tweak Invariant IndexOf logic #108709
Conversation
Tagging subscribers to this area: @dotnet/area-system-globalization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MihaZupan for your help with this issue!
/backport to release/9.0 |
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/11262961938 |
/backport to release/8.0-staging |
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/11262967394 |
Co-authored-by: Tarek Mahmoud Sayed <[email protected]>
Follow-up after #108499
Contributes to #108669
Reverts the change on the case-sensitive path, and changes the ignore-case path to create the
remainingSource
slice only when it's needed. This takes away some overhead when we do find a match, and avoids having to keep the extra state around during the main loop.Example change:
MihuBot/runtime-utils#710
MihuBot/runtime-utils#711