Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Handle retbuf definitions precisely in physical promotion's liveness #104551

Merged

Conversation

jakobbotsch
Copy link
Member

Finding the actual type defined by the call requires going from the LCL_ADDR to the CALL node, which was never implemented.
This implements the logic by simply searching for the parent in the containing statement.

Fix #86711

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 8, 2024
@jakobbotsch jakobbotsch changed the title JIT: Handle retbuf definitions precise in physical promotion's liveness JIT: Handle retbuf definitions precisely in physical promotion's liveness Jul 8, 2024
@jakobbotsch jakobbotsch marked this pull request as ready for review July 8, 2024 18:57
@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib PTAL @AndyAyersMS

Very minor diffs. Will probably be slightly bigger with #104467.

@jakobbotsch jakobbotsch requested a review from AndyAyersMS July 8, 2024 19:00
@jakobbotsch
Copy link
Member Author

/azp run runtime-coreclr superpmi-diffs

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jakobbotsch
Copy link
Member Author

Indeed slightly larger diffs now, but nothing significant.

@jakobbotsch jakobbotsch merged commit 528b6fc into dotnet:main Jul 9, 2024
101 of 107 checks passed
@jakobbotsch jakobbotsch deleted the fix-physical-promotion-retbuf-liveness branch July 9, 2024 15:31
matouskozak added a commit to matouskozak/runtime that referenced this pull request Jul 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIT: Handle liveness for defined retbufs in physical promotion
2 participants