ARM64-SVE: LeadingSignCount, LeadingZeroCount, PopCount #102548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note regarding the |
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
a74nh
changed the title
|
I get some failures in the stress test due to In the meantime, marking this as ready for review. @dotnet/arm64-contrib @kunalspathak |
| @@ -68,6 +68,8 @@ HARDWARE_INTRINSIC(Sve, FusedMultiplyAddNegated, | |||
| HARDWARE_INTRINSIC(Sve, FusedMultiplySubtract, -1, -1, false, {INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_sve_fmls, INS_sve_fmls}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_EmbeddedMaskedOperation|HW_Flag_HasRMWSemantics|HW_Flag_LowMaskedOperation|HW_Flag_FmaIntrinsic|HW_Flag_SpecialCodeGen) | |||
| HARDWARE_INTRINSIC(Sve, FusedMultiplySubtractBySelectedScalar, -1, 4, true, {INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_sve_fmls, INS_sve_fmls}, HW_Category_SIMDByIndexedElement, HW_Flag_Scalable|HW_Flag_HasImmediateOperand|HW_Flag_HasRMWSemantics|HW_Flag_FmaIntrinsic|HW_Flag_LowVectorOperation) | |||
| HARDWARE_INTRINSIC(Sve, FusedMultiplySubtractNegated, -1, -1, false, {INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_sve_fnmls, INS_sve_fnmls}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_EmbeddedMaskedOperation|HW_Flag_HasRMWSemantics|HW_Flag_LowMaskedOperation|HW_Flag_FmaIntrinsic|HW_Flag_SpecialCodeGen) | |||
| HARDWARE_INTRINSIC(Sve, LeadingSignCount, -1, -1, false, {INS_sve_cls, INS_invalid, INS_sve_cls, INS_invalid, INS_sve_cls, INS_invalid, INS_sve_cls, INS_invalid, INS_invalid, INS_invalid}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_BaseTypeFromFirstArg|HW_Flag_EmbeddedMaskedOperation) | |||
There was a problem hiding this comment.
these 2 are missing the flag for HW_Flag_LowMaskedOperation
There was a problem hiding this comment.
I really did think I had added that! Thanks for fixing.
|
/ba-g Issues seems to be #100174 |
steveharter
pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
* ARM64-SVE: LeadingSignCount + LeadingZeroCount * Add popcount * Fix PlatformNotSupported * Fix summary headers for popcount * Use SveSimpleVecOpTest for unsigned popcounts * Add HW_Flag_LowMaskedOperation() to LeadingSignCount() and LeadingZeroCount() --------- Co-authored-by: Kunal Pathak <[email protected]>
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
* ARM64-SVE: LeadingSignCount + LeadingZeroCount * Add popcount * Fix PlatformNotSupported * Fix summary headers for popcount * Use SveSimpleVecOpTest for unsigned popcounts * Add HW_Flag_LowMaskedOperation() to LeadingSignCount() and LeadingZeroCount() --------- Co-authored-by: Kunal Pathak <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_SveMasklessUnaryOpTestTemplate is the same as _SveUnaryOpTestTemplate, but without the Conditional Select tests.
For all these, the API method has a different Op1 and Return type and so does not fit into a standard conditional select test.
For LeadingSignCount, LeadingZeroCount the underlying instruction does not have a mask, so can't be optimised using conditional select.