Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] [android] System.Net.NetworkInformation.Tests.IPGlobalPropertiesTest.IPGlobalProperties_DomainName_ReturnsEmptyStringWhenNotSet fails #109280

Closed
jkurdek opened this issue Oct 28, 2024 · 7 comments
Assignees
Labels
arch-arm64 arch-x64 area-System.Net Known Build Error Use this to report build issues in the .NET Helix tab os-android
Milestone

Comments

@jkurdek
Copy link
Member

jkurdek commented Oct 28, 2024

android_arm64_release_allsubsets_mono. Also arm, x64, x86.

Stack trace

10-28 05:55:04.448 11762 11805 I DOTNET  : Failed tests:
10-28 05:55:04.448 11762 11805 I DOTNET  : 1) 	[FAIL] System.Net.NetworkInformation.Tests.IPGlobalPropertiesTest.IPGlobalProperties_DomainName_ReturnsEmptyStringWhenNotSet   Test name: System.Net.NetworkInformation.Tests.IPGlobalPropertiesTest.IPGlobalProperties_DomainName_ReturnsEmptyStringWhenNotSet
10-28 05:55:04.448 11762 11805 I DOTNET  :    Assembly:  [System.Net.NetworkInformation.Functional.Tests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]
10-28 05:55:04.448 11762 11805 I DOTNET  :    Exception messages: Assert.Equal() Failure: Strings differ
10-28 05:55:04.448 11762 11805 I DOTNET  : Expected: ""
10-28 05:55:04.448 11762 11805 I DOTNET  : Actual:   "localdomain"
10-28 05:55:04.448 11762 11805 I DOTNET  :            Γåæ (pos 0)   Exception stack traces:    at System.Net.NetworkInformation.Tests.IPGlobalPropertiesTest.IPGlobalProperties_DomainName_ReturnsEmptyStringWhenNotSet() in /_/src/libraries/System.Net.NetworkInformation/tests/FunctionalTests/IPGlobalPropertiesTest.cs:line 215
10-28 05:55:04.448 11762 11805 I DOTNET  :    at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
10-28 05:55:04.448 11762 11805 I DOTNET  :    at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Build Information

Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=850434
Build error leg or test failing: System.Net.NetworkInformation.Tests.IPGlobalPropertiesTest.IPGlobalProperties_DomainName_ReturnsEmptyStringWhenNotSet

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "System.Net.NetworkInformation.Tests.IPGlobalPropertiesTest.IPGlobalProperties_DomainName_ReturnsEmptyStringWhenNotSet",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=850434
Error message validated: [System.Net.NetworkInformation.Tests.IPGlobalPropertiesTest.IPGlobalProperties_DomainName_ReturnsEmptyStringWhenNotSet]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 10/28/2024 1:39:53 PM UTC

Report

Build Definition Test Pull Request
881982 dotnet/runtime System.Net.NetworkInformation.Tests.IPGlobalPropertiesTest.IPGlobalProperties_DomainName_ReturnsEmptyStringWhenNotSet

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 1
@jkurdek jkurdek added arch-arm64 arch-x64 area-System.Net Known Build Error Use this to report build issues in the .NET Helix tab os-android labels Oct 28, 2024
Copy link
Contributor

Tagging subscribers to 'arch-android': @vitek-karas, @simonrozsival, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Oct 28, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@matouskozak
Copy link
Member

The range for regression is a09ad52...10ee2b1. Possibly related to #107241, @wfurt could you please check it out?

@wfurt
Copy link
Member

wfurt commented Nov 16, 2024

it is likely @matouskozak. At least the test was added there. It seems like Android injects something there. I guess one option would be to simply skip this test on Android. Any thoughts on this @simonrozsival ?

@simonrozsival
Copy link
Member

@matouskozak @wfurt this seems to be the default value on Android. I am not sure if this is the default/fallback value in the bionic libc or if Android calls setdomainname("localdomain") and it is a valid value. I think we should just skip this test because Android.

@wfurt
Copy link
Member

wfurt commented Nov 21, 2024

I look at the test again @antonfirsov and I think we should update the assert to expect the localdomain on Android. I think I would prefer that over disabling the test.

@antonfirsov antonfirsov removed the untriaged New issue has not been triaged by the area owner label Nov 22, 2024
@antonfirsov antonfirsov added this to the 10.0.0 milestone Nov 22, 2024
@matouskozak
Copy link
Member

matouskozak commented Dec 27, 2024

Fixed in #110070, thank you @antonfirsov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-arm64 arch-x64 area-System.Net Known Build Error Use this to report build issues in the .NET Helix tab os-android
Projects
None yet
Development

No branches or pull requests

5 participants