Skip to content

Commit

Permalink
[wasm] Debugger tests - fix build (#82958)
Browse files Browse the repository at this point in the history
* [wasm] Debugger tests - fix build

`/workspaces/runtime/src/mono/wasm/debugger/DebuggerTestSuite/TestHarnessProxy.cs(135,44): error CS8601: Possible null reference assignment`

Started being hit with #82479 .
The other instances of this were fixed in
#82803 .

* CI: Trigger all the wasm jobs, when roslyn is updated

And this includes the debugger tests
  • Loading branch information
radical authored Mar 3, 2023
1 parent f59a3f5 commit f46caec
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions eng/pipelines/common/xplat-setup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,11 @@ jobs:
eq(dependencies.evaluate_paths.outputs['DarcDependenciesChanged.Microsoft_NET_Workload_Emscripten_Current_Manifest-8_0_100-preview_3'], true),
eq(dependencies.evaluate_paths.outputs['DarcDependenciesChanged.Microsoft_DotNet_Build_Tasks_Workloads'], true),
eq(dependencies.evaluate_paths.outputs['DarcDependenciesChanged.System_Runtime_TimeZoneData'], true),
eq(dependencies.evaluate_paths.outputs['DarcDependenciesChanged.Microsoft_Net_Compilers_Toolset'], true),
eq(dependencies.evaluate_paths.outputs['DarcDependenciesChanged.Microsoft_CodeAnalysis'], true),
eq(dependencies.evaluate_paths.outputs['DarcDependenciesChanged.Microsoft_CodeAnalysis_CSharp'], true),
eq(dependencies.evaluate_paths.outputs['DarcDependenciesChanged.Microsoft_CodeAnalysis_Analyzers'], true),
eq(dependencies.evaluate_paths.outputs['DarcDependenciesChanged.Microsoft_CodeAnalysis_NetAnalyzers'], true),
eq(dependencies.evaluate_paths.outputs['DarcDependenciesChanged.Microsoft_NET_ILLink_Tasks'], true)) ]

- ${{ each variable in parameters.variables }}:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ public static void RegisterProxyExitState(string id, RunLoopExitState status)
s_statusTable[id] = status;
// we have the explicit state now, so we can drop the reference
// to the proxy
s_proxyTable.TryRemove(id, out WeakReference<DebuggerProxyBase> _);
s_proxyTable.TryRemove(id, out _);

if (s_exitHandlers.TryRemove(intId, out WeakReference<Action<RunLoopExitState>>? handlerRef)
&& handlerRef.TryGetTarget(out Action<RunLoopExitState>? handler))
Expand Down

0 comments on commit f46caec

Please sign in to comment.