Use native wasm atomic fence instead of calling C for memory barriers

dotnet · Sep 5, 2024 · 26ad367 · 26ad367
1 parent 568796a
commit 26ad367
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 13 deletions.
diff --git a/src/mono/browser/runtime/jiterpreter-trace-generator.ts b/src/mono/browser/runtime/jiterpreter-trace-generator.ts
@@ -10,7 +10,7 @@ import {
 } from "./memory";
 import {
     WasmOpcode, WasmSimdOpcode, WasmValtype,
-    getOpcodeName, MintOpArgType
+    getOpcodeName, MintOpArgType, WasmAtomicOpcode
 } from "./jiterpreter-opcodes";
 import {
     MintOpcode, SimdInfo,
@@ -3956,7 +3956,7 @@ function emit_atomics (
 ) {
     if (opcode === MintOpcode.MINT_MONO_MEMORY_BARRIER) {
         if (WasmEnableThreads)
-            builder.callImport("membar");
+            builder.appendAtomic(WasmAtomicOpcode.atomic_fence);
         return true;
     }
 

diff --git a/src/mono/browser/runtime/jiterpreter.ts b/src/mono/browser/runtime/jiterpreter.ts
@@ -286,7 +286,6 @@ function getTraceImports () {
         ["stelemr_tc", "stelemr", getRawCwrap("mono_jiterp_stelem_ref")],
         importDef("fma", getRawCwrap("fma")),
         importDef("fmaf", getRawCwrap("fmaf")),
-        importDef("membar", getRawCwrap("mono_jiterp_memory_barrier")),
     ];
 
     if (instrumentedMethodNames.length > 0) {
@@ -664,11 +663,6 @@ function initialize_builder (builder: WasmBuilder) {
         },
         WasmValtype.void, true
     );
-    builder.defineType(
-        "membar",
-        {},
-        WasmValtype.void, true
-    );
 
     const traceImports = getTraceImports();
 

diff --git a/src/mono/mono/mini/interp/jiterpreter.c b/src/mono/mono/mini/interp/jiterpreter.c
@@ -1165,11 +1165,6 @@ mono_jiterp_stelem_ref (
 	return 1;
 }
 
-EMSCRIPTEN_KEEPALIVE void
-mono_jiterp_memory_barrier () {
-	mono_memory_barrier ();
-}
-
 
 // keep in sync with jiterpreter-enums.ts JiterpMember
 enum {