Set state of enumerator object to "after" during disposal #76090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
untriaged
333fred
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Will @BillWagner need to do any manual work to get this published, since it's a new doc? Or will it flow automatically?
jaredpar
removed
the
untriaged
|
The breaking change was approved in email. I'll go ahead and merge. |
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76078 (scenarios where resuming iteration after disposal can continue executing user code).
This change is pending on approval for breaking change. This behavior exists as far back as the native compiler.
Note: there are more scenarios left where we don't properly set the state to "after", but the impact is much less impactful. Filed follow-up issue #76089 (scenarios where iterating a second time will allocate a new enumerator instance).