Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the version of Microsoft.Net.Test.SDK #31451

Closed
wants to merge 1 commit into from

Conversation

agocke
Copy link
Member

@agocke agocke commented Nov 29, 2018

Using the RTM version allows 'dotnet test' to work and it doesn't appear
that we have any reference conflicts anymore.

Using the RTM version allows 'dotnet test' to work and it doesn't appear
that we have any reference conflicts anymore.
@agocke agocke requested review from tmat and jaredpar November 29, 2018 23:05
@agocke agocke requested review from a team as code owners November 29, 2018 23:05
@tmat
Copy link
Member

tmat commented Nov 29, 2018

I'd rather not do this as long as the SDK has the extra package references. Maybe we don't have any conflicts now but that doesn't mean some change in dependencies won't cause the conflicts to appear again.

With #30330 the value of dotnet test is diminished.

@agocke
Copy link
Member Author

agocke commented Nov 29, 2018

I don't like the alternative approach. It makes the Roslyn repo weird and requires me to remember a different sublanguage for running tests, as opposed to just reading the dotnet test documentation.

@tmat
Copy link
Member

tmat commented Nov 29, 2018

Unfortunately dotnet test does not have the features we need and the command can't be amended since it does not translate to a target invocation.

We can add the RTM reference once microsoft/vstest#1764 is fixed.

@agocke agocke closed this Nov 29, 2018
@agocke agocke deleted the update-test-fx-version branch November 29, 2018 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants