Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trim warning in ResilienceHandlerContext #4624

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Fix trim warning in ResilienceHandlerContext #4624

merged 1 commit into from
Oct 27, 2023

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Oct 27, 2023 •
edited by ghost
Loading

Contributes to #4622

Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned eerhardt Oct 27, 2023
joperezr
joperezr approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this one. We will work on enabling the analyzer on the repo so that we can take a look at what other warnings we get.

@joperezr joperezr merged commit 14943b9 into dotnet:main Oct 27, 2023
6 checks passed
@ghost ghost added this to the 9.0-preview1 milestone Oct 27, 2023
@joperezr
Copy link
Member

/backport to release/8.0

@github-actions
Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/extensions/actions/runs/6669973349

@github-actions github-actions bot mentioned this pull request Oct 27, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joperezr joperezr joperezr approved these changes

@davidfowl davidfowl Awaiting requested review from davidfowl

Assignees

@eerhardt eerhardt

Labels
None yet
Projects
None yet
Milestone
9.0-preview1
Development

Successfully merging this pull request may close these issues.
2 participants
@eerhardt @joperezr