-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped NDK version to 27 #1278
base: main
Are you sure you want to change the base?
Bumped NDK version to 27 #1278
Conversation
Can you remove the deletion of clang-tidy now that we're updating the NDK? |
@jkoritzinsky should we also remove the deletion of python site packages? NDK 27 contains python 3.11 |
I'm not sure if we can remove the site packages deletion. If you try locally, can you run |
I checked - python site packages need to be removed. Also, even after removing site packages the output is not entirely clear. There are some vulnerabilities around |
What's the path of the The System.Formats.Asn1 one isn't one I'm worried about (as that's one of our packages, the docker team knows how to fix that one). |
npm/cross-spawn is coming from The System.Formats.Asn1 is coming from |
@@ -27,8 +27,7 @@ RUN /usr/local/cmdline-tools/cmdline-tools/bin/sdkmanager --sdk_root="${ANDROID_ | |||
|
|||
# We can't upgrade the NDK version as the runtime repo requires tooling that only exists up to NDK 23 | |||
# Remove all components of NDK 23 that are flagged by security scanners |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment should be updated since it doesn't apply anymore
In that case, I think both of those are "fine" in the sense that S360 hasn't flagged them for us to fix. |
We could also remove the manual copying of Java since Azure Linux 3.0 now provides an out of the box package for |
@akoeplinger if we remove Java copying here, what runtime changes would we have to implement? |
none, we'd just install the |
Updates the container to use LTS Android NDK. Should be merged just before the runtime changes PR: dotnet/runtime#110393