Improved logging

dotnet · May 2, 2024 · 3fc2809 · 3fc2809
1 parent 55b3879
commit 3fc2809
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/cluster/DotNext.Net.Cluster/Net/Cluster/Consensus/Raft/LeaderState.Replication.cs b/src/cluster/DotNext.Net.Cluster/Net/Cluster/Consensus/Raft/LeaderState.Replication.cs
@@ -111,7 +111,7 @@ internal ValueTask<Result<bool>> ReplicateAsync(IAuditTrail<IRaftLogEntry> audit
             var startIndex = replicationIndex + 1L;
             Debug.Assert(startIndex == Member.State.NextIndex);
 
-            logger.ReplicationStarted(Member.EndPoint, startIndex);
+            logger.ReplicationStarted(Member.EndPoint, startIndex, currentIndex);
             return auditTrail.ReadAsync(this, startIndex, currentIndex, token);
         }
 
@@ -168,7 +168,7 @@ private ConfiguredTaskAwaitable<Result<HeartbeatResult>>.ConfiguredTaskAwaiter R
         {
             Debug.Assert(snapshot.IsSnapshot);
 
-            logger.InstallingSnapshot(replicationIndex = snapshotIndex);
+            logger.InstallingSnapshot(Member.EndPoint, replicationIndex = snapshotIndex);
             var result = Member.InstallSnapshotAsync(term, snapshot, snapshotIndex, token).ConfigureAwait(false).GetAwaiter();
             fingerprint = Member.State.ConfigurationFingerprint; // keep local version unchanged
             return result;

diff --git a/src/cluster/DotNext.Net.Cluster/Net/Cluster/Consensus/Raft/LogMessages.cs b/src/cluster/DotNext.Net.Cluster/Net/Cluster/Consensus/Raft/LogMessages.cs
@@ -110,10 +110,10 @@ internal static partial class LogMessages
     [LoggerMessage(
         EventIdOffset + 12,
         LogLevel.Debug,
-        "Replication of member {Member} started at log index {EntryIndex}",
+        "Replication of member {Member} started from {StartIndex} log index to {EndIndex}",
         EventName = $"{EventIdPrefix}.{nameof(ReplicationStarted)}"
     )]
-    public static partial void ReplicationStarted(this ILogger logger, EndPoint member, long entryIndex);
+    public static partial void ReplicationStarted(this ILogger logger, EndPoint member, long startIndex, long endIndex);
 
     [LoggerMessage(
         EventIdOffset + 13,
@@ -158,10 +158,10 @@ internal static partial class LogMessages
     [LoggerMessage(
         EventIdOffset + 18,
         LogLevel.Information,
-        "Installing snapshot at index {EntryIndex}",
+        "Installing snapshot at index {EntryIndex} for member {Member}",
         EventName = $"{EventIdPrefix}.{nameof(InstallingSnapshot)}"
     )]
-    public static partial void InstallingSnapshot(this ILogger logger, long entryIndex);
+    public static partial void InstallingSnapshot(this ILogger logger, EndPoint member, long entryIndex);
 
     public const string SnapshotInstallationFailed = "Critical error detected while installing snapshot of audit trail";