Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable retries for APP_CRASH results on iOS/AppleTV devices #11689

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Enable retries for APP_CRASH results on iOS/AppleTV devices #11689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.DotNet.Helix/Sdk/tools/xharness-runner/xharness-event-processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,8 @@ def analyze_operation(command: str, platform: str, device: str, is_device: bool,

global retry, reboot, android_connectivity_verified

# Apps crashing can be infra failures, retry except on Apple devices where retries can be costly due to small queue size
if exit_code == 80 and not (platform == "apple" and is_device): # APP_CRASH
# Apps crashing can be infra failures too (this is a gray zone)
if exit_code == 80: # APP_CRASH
premun marked this conversation as resolved.
Show resolved Hide resolved
print(f' Application crashed - if persist, please investigate system logs from the run')
retry = True
reboot = True
Expand Down