Remove custom Maestro swagger page (#3847)

eng/enforce-issue.ps1

@@ -28,10 +28,14 @@ elseif ($prDetail.title -match "\[automated\]") {
 $hasIssue = $prDetail.body -Match "github\.com/dotnet/(.+)/issues/(\d+)"
 if (-not $hasIssue) {
 	# Or for https://dev.azure.com/dnceng/internal/_workitems/edit/45126
-	$hasIssue = $prDetail.body -Match "dev\.azure\.com/dnceng/internal/_workitems"
+	$hasIssue = $prDetail.body -Match "dev\.azure\.com/(.+)/(.+)/_workitems"
 	if (-not $hasIssue) {
-		Write-Host "##vso[task.LogIssue type=error;]Link to the corresponding GitHub/AzDO issue is missing in the PR description. Check failed."
-		exit 1
+		# Or for https://dev.azure.com/dnceng/internal/_workitems/edit/12345
+		$hasIssue = $prDetail.body -Match "(.+)\.visualstudio\.com/(.+)/_workitems"
+		if (-not $hasIssue) {
+			Write-Host "##vso[task.LogIssue type=error;]Link to the corresponding GitHub/AzDO issue is missing in the PR description. Check failed."
+			exit 1
+		}
 	}
 }
 

src/Maestro/Maestro.Web/Maestro.Web.csproj

@@ -45,6 +45,9 @@
     <PackageReference Include="Microsoft.VisualStudio.Web.BrowserLink" />
     <PackageReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Design" />
     <PackageReference Include="Octokit" />
+    <PackageReference Include="Swashbuckle.AspNetCore" />
+    <PackageReference Include="Swashbuckle.AspNetCore.Newtonsoft" />
+    <PackageReference Include="Swashbuckle.AspNetCore.SwaggerGen" />
     <PackageReference Include="System.Text.Encodings.Web" />
     <!--
       NuGet.Protocol is not directly used but it's a transitive dependency of Microsoft.VisualStudio.Web.CodeGeneration.Design.

src/Maestro/Maestro.Web/Startup.cs

@@ -190,7 +190,6 @@ public override void ConfigureServices(IServiceCollection services)
                 options.Conventions.AuthorizeFolder("/", AuthenticationConfiguration.MsftAuthorizationPolicyName);
                 options.Conventions.AllowAnonymousToPage("/Index");
                 options.Conventions.AllowAnonymousToPage("/Error");
-                options.Conventions.AllowAnonymousToPage("/SwaggerUi");
             })
             .AddFluentValidation(options => options.RegisterValidatorsFromAssemblyContaining<Startup>())
             .AddGitHubWebHooks()
@@ -294,7 +293,7 @@ public override void ConfigureServices(IServiceCollection services)
                     doc.Servers = new List<OpenApiServer>
                     {
                         new() {
-                            Url = $"{(http ? "http" : "https")}://{req.Host.Value}/",
+                            Url = $"{req.Scheme}://{req.Host.Value}/",
                         },
                     };
 
@@ -411,7 +410,6 @@ private void ConfigureApi(IApplicationBuilder app)
 
                 return next();
             });
-        app.UseSwagger();
 
         app.UseAuthentication();
         app.UseRouting();
@@ -489,6 +487,20 @@ public override void Configure(IApplicationBuilder app)
                         new PhysicalFileProvider(Path.Combine(Environment.CurrentDirectory, "wwwroot"))),
                 });
             }
+
+            app.UseSwagger();
+            app.UseSwaggerUI(options => // Enable Swagger UI only in local dev env
+            {
+                options.DocumentTitle = "Maestro API";
+
+                var versions = app.ApplicationServices.GetRequiredService<VersionedControllerProvider>().Versions.Keys
+                    .OrderByDescending(x => x);
+
+                foreach (var version in versions)
+                {
+                    options.SwaggerEndpoint($"/api/{version}/swagger.json", $"Maestro API {version}");
+                }
+            });
         }
         else
         {
@@ -554,7 +566,6 @@ public override void Configure(IApplicationBuilder app)
                 ConfigureCookieAuthedApi);
         }
 
-        app.UseRewriter(new RewriteOptions().AddRedirect("^swagger(/ui)?/?$", "/swagger/ui/index.html"));
         app.UseStatusCodePagesWithReExecute("/Error", "?code={0}");
         app.UseCookiePolicy();
         app.UseStaticFiles();