-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce automated test crashes #2968
Open
edwardneal
wants to merge
7
commits into
dotnet:main
Choose a base branch
from
edwardneal:stabilise-test-threading
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Nov 3, 2024
-
Converted Threads to long-running Tasks
The key advantage is that exceptions propagate properly. If a thread throws an exception (as a result of a failed test assertion, or otherwise) then the test host crashes and must be restarted.
Configuration menu - View commit details
-
Copy full SHA for 848241d - Browse repository at this point
Copy the full SHA 848241dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bd9b8a - Browse repository at this point
Copy the full SHA 4bd9b8aView commit details -
Changes to TestSqlCommandCancel, eliminating timing-specific cancella…
…tion behaviour testing. This should also allow the test to run on both netcore and netfx.
Configuration menu - View commit details
-
Copy full SHA for 7c766b4 - Browse repository at this point
Copy the full SHA 7c766b4View commit details
Commits on Nov 13, 2024
-
* Removed two unnecessary iterations from DatabaseHelper. * Added explanatory comments to ApiShould. * Switched to using Task.WaitAll rather than waiting for each Task in sequence.
Configuration menu - View commit details
-
Copy full SHA for ad1a572 - Browse repository at this point
Copy the full SHA ad1a572View commit details
Commits on Nov 15, 2024
-
Improve cancellation detection
Cancellation can trigger one of several different errors, resulting in a flakier test. Also ensure that the query always takes more than 150ms, ensuring that a quick query execution doesn't cause the test to fail. Finally, make sure that we try to read everything from the SqlDataReader.
Configuration menu - View commit details
-
Copy full SHA for db4945e - Browse repository at this point
Copy the full SHA db4945eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 35d4607 - Browse repository at this point
Copy the full SHA 35d4607View commit details -
Configuration menu - View commit details
-
Copy full SHA for 821ea46 - Browse repository at this point
Copy the full SHA 821ea46View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.