Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce automated test crashes #2968

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Commits on Nov 3, 2024

  1. Converted Threads to long-running Tasks

    The key advantage is that exceptions propagate properly.
    If a thread throws an exception (as a result of a failed test assertion, or otherwise) then the test host crashes and must be restarted.
    edwardneal committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    848241d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4bd9b8a View commit details
    Browse the repository at this point in the history
  3. Changes to TestSqlCommandCancel, eliminating timing-specific cancella…

    …tion behaviour testing.
    
    This should also allow the test to run on both netcore and netfx.
    edwardneal committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    7c766b4 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Responding to code review.

    * Removed two unnecessary iterations from DatabaseHelper.
    * Added explanatory comments to ApiShould.
    * Switched to using Task.WaitAll rather than waiting for each Task in sequence.
    edwardneal committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ad1a572 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Improve cancellation detection

    Cancellation can trigger one of several different errors, resulting in a flakier test.
    Also ensure that the query always takes more than 150ms, ensuring that a quick query execution doesn't cause the test to fail.
    Finally, make sure that we try to read everything from the SqlDataReader.
    edwardneal committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    db4945e View commit details
    Browse the repository at this point in the history
  2. Merge upstream

    edwardneal committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    35d4607 View commit details
    Browse the repository at this point in the history
  3. Correcting previous merge

    edwardneal committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    821ea46 View commit details
    Browse the repository at this point in the history