Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target .NET 7 in Standalone version #607

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bdovaz
Copy link
Contributor

@bdovaz bdovaz commented Nov 5, 2023

  1. I have added target net7.0 / net7.0-windows in all projects to be able to use an updated code base to .NET 7 with the benefit that you get from it in the standalone / ClickOne version.
  2. I have changed the target of the ResXManager project from .NET Framework to .NET 7.
  3. I have changed the ClickOnce profile dependencies so that it installs the .NET 7 runtime.
  4. I have removed the net472 target in Model / Infrastructure projects because with netstandard2.0 it is already implicit: https://learn.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-2-0#select-net-standard-version
  5. I have replaced WindowsAPICodePack-Shell with Microsoft-WindowsAPICodePack-Shell which is an updated fork, the previous one has compatibility problems being abandoned: https://www.nuget.org/packages/Microsoft-WindowsAPICodePack-Shell/#readme-body-tab

@tom-englert about your #598 (comment) concern.

There have been 4-5 warnings generated when targeting .NET 7 but I think they are all fixable without having to do conditional code. I can solve them or if you want, compile it yourself from this branch and take a look at them to see what to do with each one.

@bdovaz
Copy link
Contributor Author

bdovaz commented Nov 5, 2023

@tom-englert
Copy link
Collaborator

Again: Which serious issue would that fix?

@bdovaz
Copy link
Contributor Author

bdovaz commented Nov 6, 2023

No serious problem, just not using old frameworks (where possible == standalone version) in a project that is still under development and continuous maintenance.

The benefits are as I say, use a more updated code base and unless any API changes, it is transparent to us. And as you can see, there are 4 or 5 warnings when targeting .NET 7 but they are easy to fix if you want to fix them because I see that the project currently has some other info or warning issues not fixed (I think I remember).

@tom-englert
Copy link
Collaborator

#593 (comment)

Here you reacted with thumbs up, and now you are doing it just again ❓

@bdovaz
Copy link
Contributor Author

bdovaz commented Nov 11, 2023

#593 (comment)

Here you reacted with thumbs up, and now you are doing it just again ❓

I simply had a conflict in a csproj that could be resolved through the GitHub web interface and I fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants