Diagnostics #213

ardalis · 2015-05-06T20:05:01Z

Fixes issue #62

… implemented yet in the source.

Added placeholder for the article and issue dotnet#212

Updated article content accordingly.

dnfclas · 2015-05-08T17:42:35Z

@ardalis, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

danroth27 · 2015-05-11T17:53:16Z

@glennc @Tratcher Please review

danroth27 · 2015-05-11T17:59:32Z

docs/fundamentals/diagnostics.rst

+	:linenos:
+	:emphasize-lines: 2,21
+
+The above code, which is built from the ASP.NET 5 Empty template, includes a simple mechanism for creating an exception on line 36. If a request includes a non-empty querystring parameter for the variable ``throw`` (e.g. a path of ``/?throw=true``), an exception will be thrown. Line 21 makes the call to ``UseErrorPage()`` with `ErrorPageOptions <https://github.com/aspnet/Diagnostics/blob/dev/src/Microsoft.AspNet.Diagnostics/ErrorPageOptions.cs>`_ set to ``ShowAll``. Using ``ErrorPageOption`` you can toggle the visibility of the following features of the error page:


ErrorPageOption -> ErrorPageOptions

danroth27 · 2015-05-11T18:49:34Z

There are still AppInsights images in this PR that are not referenced and should be removed:

azure-create-appinsight.png
config-json.png
nuget-pacakge-manager.png
manage-nuget-packages.png

ardalis · 2015-05-11T18:53:19Z

The images are fixed in the AppInsights PR, just submitted.

danroth27 · 2015-05-11T19:10:17Z

I'd rather not couple this PR with the AppInsights PR. Can we please remove the AppInsights images from this PR and add them in the correct PR?

ardalis · 2015-05-11T20:13:59Z

Images removed.

Tratcher · 2015-05-11T21:02:20Z

docs/fundamentals/diagnostics/sample/src/DiagDemo/project.json

+    "dependencies": {
+        "Microsoft.AspNet.Server.IIS": "1.0.0-beta4",
+        "Microsoft.AspNet.Server.WebListener": "1.0.0-beta4",
+        "Microsoft.AspNet.Diagnostics": "1.0.0-beta4"


Add Kestrel. https://github.com/aspnet/WebSockets/blob/dev/test/AutobahnTestServer/Project.json#L8-L12

Tratcher · 2015-05-11T21:32:49Z

docs/fundamentals/diagnostics.rst

+
+.. image:: diagnostics/_static/errorpage-headers.png
+
+Finally, any environment variables defined for the server environment would be displayed on the Environment tab.


Remove any reference to the environment tab, it's a leftover from Katana referring to the OWIN environment, not environment variables. aspnet/Diagnostics#135

Tratcher · 2015-05-11T21:43:19Z

@danroth27 Is UseErrorHandler going to get it's own doc page?

danroth27 · 2015-05-11T21:49:36Z

@Tratcher Yes, I think we should cover it as part of the Error Handling topic (#67).

Tratcher · 2015-05-11T21:54:26Z

Ok, then we should take it out of this sample, or at least put in a link to the other docs from that line in the sample.

@Tratcher

Fixed a few things in the article per @Tratcher feedback

Tratcher · 2015-05-12T20:44:17Z

docs/fundamentals/diagnostics/sample/src/DiagDemo/project.lock.json

@@ -0,0 +1,1146 @@
+{


@danroth27 do we want to check in lock files for samples? We don't do that elsewhere.

Agreed, we don't do it anywhere else.

Sorry, that should be in my .gitignore.

Added links to welcome page and exception from home page

ardalis · 2015-05-12T20:45:10Z

Should be good to go now, @Tratcher thanks!

Tratcher · 2015-05-12T21:09:18Z

docs/fundamentals/diagnostics/sample/src/DiagDemo/project.json

+    },
+
+    "frameworks": {
+        "dnx451": { }/*,


/*...*/ comments are no longer supported, remove them. The sample should work on dnxcore50.

danroth27 · 2015-05-12T21:34:26Z

…cified in project.json. Updated gitignore - added project.lock.json

Conflicts: docs/fundamentals/diagnostics.rst docs/fundamentals/index.rst

Diagnostics

ardalis added 6 commits May 5, 2015 14:07

Initial version and sample project

7c16219

Documenting error page implementation - it doesn't appear to be fully…

5764b49

… implemented yet in the source.

Covered welcome page, runtime info page, and error page options

2c15ca7

adding Application Insights

dca55a2

Pull application insights out of diagnostics article

c40c88c

Added placeholder for the article and issue dotnet#212

Added environment check to Configure()

822402e

Updated article content accordingly.

dnfclas added the cla-required label May 6, 2015

dnfclas added cla-signed and removed cla-required labels May 8, 2015

danroth27 reviewed May 11, 2015
View reviewed changes

ardalis added 2 commits May 11, 2015 14:55

Crop whitespace.

ce7c7c0

Tweaked wording per @danroth27 feedback

cea7915

AppInsights images removed.

072c2ad

Tratcher reviewed May 11, 2015
View reviewed changes

ardalis added 2 commits May 12, 2015 15:18

Fixed framework version

d29981f

Fixed a few things in the article per @Tratcher feedback

Updated per @Tratcher feedback

40194d3

Tratcher reviewed May 12, 2015
View reviewed changes

Updated lauchsettings for web and kestrel

3cab094

Added links to welcome page and exception from home page

Delete project.lock.json

71d5e30

Tratcher reviewed May 12, 2015
View reviewed changes

ardalis added 2 commits May 13, 2015 12:15

Updated launchSettings with launchUrl that matches the server URL spe…

cf6b77b

…cified in project.json. Updated gitignore - added project.lock.json

Merge branch 'master' into diagnostics

7bf4a69

Conflicts: docs/fundamentals/diagnostics.rst docs/fundamentals/index.rst

ardalis added a commit that referenced this pull request May 13, 2015

Merge pull request #213 from ardalis/diagnostics

21d36a6

Diagnostics

ardalis merged commit 21d36a6 into dotnet:master May 13, 2015

ardalis deleted the diagnostics branch May 13, 2015 16:22

This was referenced Jul 13, 2021

[Snyk] Upgrade grunt-contrib-compress from 1.3.0 to 1.6.0 hixio-mh/AspNetCore.Docs#18

Open

[Snyk] Upgrade grunt-contrib-compress from 1.3.0 to 1.6.0 hixio-mh/AspNetCore.Docs#36

Open

This was referenced Apr 7, 2022

[Snyk] Fix for 1 vulnerabilities snyk123/AspNetCore.Docs#67

Open

[Snyk] Fix for 1 vulnerabilities snyk123/AspNetCore.Docs#68

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Diagnostics #213

Diagnostics #213

ardalis commented May 6, 2015

dnfclas commented May 8, 2015

danroth27 commented May 11, 2015

danroth27 May 11, 2015

ardalis May 11, 2015

danroth27 commented May 11, 2015

ardalis commented May 11, 2015

danroth27 commented May 11, 2015

ardalis commented May 11, 2015

Tratcher May 11, 2015

ardalis May 12, 2015

Tratcher May 11, 2015

ardalis May 12, 2015

Tratcher commented May 11, 2015

danroth27 commented May 11, 2015

Tratcher commented May 11, 2015

Tratcher May 12, 2015

davidfowl May 12, 2015

ardalis May 12, 2015

ardalis commented May 12, 2015

Tratcher May 12, 2015

ardalis May 13, 2015

danroth27 commented May 12, 2015


		.. image:: diagnostics/_static/errorpage-headers.png

		Finally, any environment variables defined for the server environment would be displayed on the Environment tab.

Diagnostics #213

Diagnostics #213

Conversation

ardalis commented May 6, 2015

dnfclas commented May 8, 2015

danroth27 commented May 11, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danroth27 commented May 11, 2015

ardalis commented May 11, 2015

danroth27 commented May 11, 2015

ardalis commented May 11, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tratcher commented May 11, 2015

danroth27 commented May 11, 2015

Tratcher commented May 11, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ardalis commented May 12, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danroth27 commented May 12, 2015