Update Lab 3 README.md #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update for P6 and to fix issues I hit walking through
Keycloak wasn't working for me during P6 walkthrough. Noticed start and end state are different, but lab doesn't have any instructions to change it. Changing to match end state fixed Keycloak for me, but would like to double check this is correct.
|
@DamianEdwards @davidfowl Okay to merge this? I want to keep going on updates for Lab 4 & 5 and some of the keycloak updates affected those. I'll look at the latest manifest fix commit during those updates. |
|
Doh! Need a PR approval to merge. |
DamianEdwards
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keycloak wasn't working for me during P6 walkthrough. Noticed start and end state are different, but lab doesn't have any instructions to change it. Changing to match end state fixed Keycloak for me, but would like to double check this is correct.
This pull request includes changes to the
labs/3-Add-Identity/README.mdfile to improve clarity and accuracy. The most important changes include updating the HTTPS profile for the web app, correcting typos, and providing more precise file paths for better navigation.Codebase improvements:
labs/3-Add-Identity/README.md: Updated the HTTPS profile for the web app and improved the environment variable setup for better clarity.labs/3-Add-Identity/README.md: Corrected typos and improved the description for better understanding. [1] [2] [3]File navigation improvements:
labs/3-Add-Identity/README.md: Provided more precise file paths for better navigation and understanding. [1] [2]labs/3-Add-Identity/README.md: Updated the line reference for the client secret in theeshop-realm.jsonfile for better accuracy.