Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lab 4 fixes #26

Merged
merged 6 commits into from
Feb 14, 2024
Merged

Lab 4 fixes #26

merged 6 commits into from
Feb 14, 2024

Conversation

SmithPlatts
Copy link
Contributor

@SmithPlatts SmithPlatts commented Feb 13, 2024 •
edited
Loading

  • Corrected example code for wiring the BasketService to the GRPC project.
  • Corrected incorrect initialisation/construction of CustomerBasket.
  • Corrected spelling of ConfigureDefaultJwtBearer in explanation.
  • Corrected incomplete accessor on sample method ThrowBasketDoesNotExist.
  • Updated the CartPage CSS to make the behaviour of the Update button align with other "buttons" on hover.

@SmithPlatts SmithPlatts changed the title Corrected example code for wiring the BasketService to the GRPC project Lab 4 fixes Feb 13, 2024
DamianEdwards
DamianEdwards approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@DamianEdwards DamianEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@DamianEdwards DamianEdwards merged commit 362b5f3 into dotnet-presentations:main Feb 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamianEdwards DamianEdwards DamianEdwards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SmithPlatts @DamianEdwards