Flow support - spread operator #2550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matikrk
commented
Sep 13, 2019
|
|
||
| // return interfaces.join(' & ') + (allFields.length ? ' & ' : ''); | ||
|
|
||
| return '{' + '...' + interfaces.join(', ...') + (allFields.length ? ', ...' : '}'); |
There was a problem hiding this comment.
I think to change it in a base behind isFlow flag. Will be less changes
matikrk
commented
Sep 13, 2019
| } else if (result.length === 1) { | ||
| return result[0]; | ||
| } else { | ||
| return `{\n ...` + result.join(`,\n ...`) + `\n}`; |
There was a problem hiding this comment.
I think to change it in a base behind isFlow flag. Will be less changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I started work on better flow support. Right now it generates code using spread operator, it was mentioned it in #1844
It's iteration over https://github.com/matikrk/graphql-code-generator/pull/1
Right now working will all plugins.
Extending needed methods inside flow specific classes.
It's still WIP, I have an idea to change 2 things here. But this code right now should pass all tests