Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build args to create release GH action and use it in medical dashboard #18

Open
cheyer opened this issue Jul 10, 2023 · 0 comments
Open

Comments

@cheyer
Copy link
Collaborator

cheyer commented Jul 10, 2023

All services, like e.g. the data graph, use the shared create release GH action in our .github repo:

create-release:
    name: Create Release
    needs: merge-release-pr
    uses: dot-base/.github/.github/workflows/create-release.yml@master
    secrets:
      GH_BOT_PAT: ${{ secrets.GH_BOT_PAT }}
      CR_PAT: ${{ secrets.CR_PAT }}

The medical dashboard is not using the shared GH action, as it needs the FONTAWESOME_NPM_AUTH_TOKEN env variable and sets it as a docker build arg.

Goal of this ticket is to investigate, if we can change the shared GH action to also handle additional optional docker build args, so we can use the shared GH action also in the medical dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant