Skip to content
This repository has been archived by the owner on Jan 6, 2021. It is now read-only.

Vinai/query all #68

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Vinai/query all #68

wants to merge 2 commits into from

Conversation

VinaiRachakonda
Copy link
Contributor

No description provided.

Copy link
Contributor

@casey-chow casey-chow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't do anything:

https://github.com/feathersjs-ecosystem/feathers-objection/blob/761a549e65e999cd438571f6ee38b04e1114e1ec/src/index.js#L302-304

Did you look at the workaround I linked to in the Trello?

@VinaiRachakonda
Copy link
Contributor Author

From what I understand this basically removes any query limit. I tested locally and was able to pull more than 25.

@casey-chow
Copy link
Contributor

Given that this behavior isn't documented anywhere and the code on master of feather objection indicates otherwise (I suspect master might just be ahead as a result) I'm weary of using this solution still

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants