Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.d.ts #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update index.d.ts #45

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 10, 2020

Is there any harm in doing this? So I don't have to do nested templates like:

    this.log(`Inbox contains ${green(`${inbox.files.length}`)} reports:`);
    this.log(`Valid:   ${green(`${inbox.accepted.length}`)}`);
    this.log(`Invalid: ${green(`${inbox.rejected.length}`)}`);

and just do...

    this.log(`Inbox contains ${green(inbox.files.length)} reports:`);
    this.log(`Valid:   ${green(inbox.accepted.length)}`);
    this.log(`Invalid: ${green(inbox.rejected.length)}`);

Is there any harm in doing this? So I don't have to do ugly things like:
```
    this.log(`Inbox contains ${green(`${inbox.files.length}`)} reports:`);
    this.log(`Valid:   ${green(`${inbox.accepted.length}`)}`);
    this.log(`Invalid: ${green(`${inbox.rejected.length}`)}`);
```
and just do...

```
    this.log(`Inbox contains ${green(inbox.files.length)} reports:`);
    this.log(`Valid:   ${green(inbox.accepted.length)}`);
    this.log(`Invalid: ${green(inbox.rejected.length)}`);
```
@doowb
Copy link
Owner

doowb commented Jun 8, 2021

Hi @cncshaggy ... sorry for not responding sooner and thanks for the PR!

Since the input is technically "cast" to a string here, I believe this should be any. (Also, null and undefined are valid inputs, which return an empty string)

If you'd like to update that to any, I'll get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants