Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for [Bug] PlutoGrid Unexpected null value #88 #106

Closed

Conversation

stan-at-work
Copy link

@stan-at-work stan-at-work commented Dec 6, 2024

Fix: #88

@stan-at-work stan-at-work changed the title Fix for https://github.com/doonfrs/pluto_grid_plus/issues/88 and adde… Fix for [Bug] PlutoGrid Unexpected null value #88 Dec 6, 2024
@stan-at-work
Copy link
Author

#88 (comment)

@stan-at-work stan-at-work mentioned this pull request Dec 6, 2024
@doonfrs
Copy link
Owner

doonfrs commented Dec 10, 2024

Hi @stan-at-work
Why does the whole file look changed? There is something wrong with the formatting. What do you think?

@stan-at-work
Copy link
Author

Hi @stan-at-work

Why does the whole file look changed? There is something wrong with the formatting. What do you think?

Idk probly this has something to do with it:

https://www.baeldung.com/linux/line-breaks-types#:~:text=CR%20LF%2C%20which%20stands%20for,cursor%20to%20the%20next%20line.

@stan-at-work
Copy link
Author

@doonfrs This is just a white space isse, as discribed in: #122 and #102 (comment)

Turn the Hide whitespace toggle and then you see the changes.

dasds.mp4

@stan-at-work
Copy link
Author

@doonfrs Can you approve this ?

1 similar comment
@stan-at-work
Copy link
Author

@doonfrs Can you approve this ?

@doonfrs
Copy link
Owner

doonfrs commented Jan 2, 2025

let's resubmit the change, I fixed the line endings to CR so the diff will be better

@stan-at-work
Copy link
Author

let's resubmit the change, I fixed the line endings to CR so the diff will be better

What does resubmit the change mean ?

@stan-at-work stan-at-work force-pushed the Fix-auto-fit-column-issue-88 branch from a4b926c to b905ee2 Compare January 11, 2025 13:00
@stan-at-work
Copy link
Author

@doonfrs Please just accept this, its just whitespace, that is only visible where, and does never elsewhere cause any problems.

@stan-at-work
Copy link
Author

@doonfrs I 'resubmit' my file that uses CRLF like you said you wants to be the default. is this oke for you know ? This issue has been open for a month now

@stan-at-work stan-at-work deleted the Fix-auto-fit-column-issue-88 branch January 11, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] PlutoGrid Unexpected null value.
2 participants