Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(VR): water refraction #756

Merged
merged 7 commits into from
Nov 19, 2024
Merged

fix(VR): water refraction #756

merged 7 commits into from
Nov 19, 2024

Conversation

doodlum
Copy link
Owner

@doodlum doodlum commented Nov 18, 2024

Fixes #732

@alandtse
Copy link
Collaborator

Did you test? This is where VR vanilla differed in its depth calculation and would introduce artifacts due to incorrect depth.

@doodlum
Copy link
Owner Author

doodlum commented Nov 18, 2024

Did you test? This is where VR vanilla differed in its depth calculation and would introduce artifacts due to incorrect depth.

I tested yes. The refraction was identical with my fix whereas before it didnt have any refraction at all.

@doodlum doodlum marked this pull request as draft November 18, 2024 23:52
@doodlum doodlum marked this pull request as ready for review November 19, 2024 12:32
@doodlum doodlum merged commit 2d3e962 into dev Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VR water refraction is incorrect
2 participants
@doodlum @alandtse