Tuning dispatch framework for discussion #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment tuning seems to be implemented as a function that changes the parameters of a Learner. https://github.com/dominusmi/Julia-Machine-Learning-Review/blob/master/MLR/Tuning.jl
There are issues with this, the main one being, that if you apply tuning to a model, the composition of tuning-model is forgotten and only the best performing model is returned, which is of course conditional on the data available at a time. Ideally you would want to instead get a TunedLearner object, which behaves just as your original learner for all purposes, except when you fit it to data, it automatically tuned itself.
I attached a possible implementation (discussed with and approved by one of the more experienced Julia devs, Valentin Churavy), which we can use as a basis for discussing a wider framework of composable models.