Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit tests for QiHDWallet #248

Merged

Conversation

alejoacosta74
Copy link
Contributor

Run new tests with:

npx mocha  --reporter ./reporter.cjs ./lib/commonjs/_tests/test-qi-hdwallet.js

Copy link
Member

@rileystephens28 rileystephens28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6/7 test passing. The test that is failing is not due to a failed assersion but because of a timeout.

Here is the error

Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

@@ -273,6 +273,15 @@ export enum Zone {
/////////////////////////////
// HDWallets

export interface addrParams {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to AddrParams to use same case standard as other types/interfaces

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@alejoacosta74
Copy link
Contributor Author

alejoacosta74 commented Jul 3, 2024

@rileystephens28 which is the failing test?
None is failing on my environment. It is probably due to different machine performance.
I can increase the timeout within the particular test that times out.

Or try adding the timeout explictly:

npx mocha --timeout 15000  --reporter ./reporter.cjs ./lib/commonjs/_tests/test-qi-hdwallet.js 

@rileystephens28 rileystephens28 merged commit 8da9cd2 into dominant-strategies:master Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants