New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hdnodewallet test #216

Merged

rileystephens28 merged 2 commits into dominant-strategies:master from alejoacosta74:fix-hdnodewallet-test

Jun 24, 2024

Contributor

alejoacosta74 commented Jun 24, 2024

This PR introduces the following changes:

Fix a bug in the extendedKey getter from HDNodeWallet class
Fixes the unit tests for the HDNodeWallet class:

To run the tests:

npx mocha  --reporter ./reporter.cjs ./lib/commonjs/_tests/test-wallet-hd.js

alejoacosta74 added 2 commits

June 24, 2024 14:03


          FIX: get extendedKey

0b2f8cb


          fix unit tests for HDNodeWallet

d4b91b3

alejoacosta74 requested review from rileystephens28 and robertlincecum

June 24, 2024 19:23

rileystephens28 approved these changes

View reviewed changes

Member

rileystephens28 left a comment

Looks good. Testing are all passing on my end.

rileystephens28 merged commit d77f3fe into dominant-strategies:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet