Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various wallet improvements #210

Merged
merged 8 commits into from
Jun 20, 2024
Merged

Various wallet improvements #210

merged 8 commits into from
Jun 20, 2024

Conversation

alejoacosta74
Copy link
Contributor

Changes in this PR:

  1. Removes duplicated logic in Quai and Qi HD Wallet
  2. Fixes a bug in getOutpointsByAddress() method in abstract-provider.ts
  3. Removes the _accounts map from AbstractHDWallet
  4. Adds JSDOC comments to several methods
  5. Simplies logic in some wallet methods

rileystephens28
rileystephens28 approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@rileystephens28 rileystephens28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@rileystephens28 rileystephens28 merged commit 2de857c into dominant-strategies:master Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileystephens28 rileystephens28 rileystephens28 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alejoacosta74 @rileystephens28