Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work object header #106

Merged
merged 20 commits into from
May 7, 2024
Merged

Work object header #106

merged 20 commits into from
May 7, 2024

Conversation

robertlincecum
Copy link
Contributor

No description provided.

alejoacosta74
alejoacosta74 reviewed May 6, 2024
View reviewed changes
Copy link
Contributor

@alejoacosta74 alejoacosta74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick comment: I see a lot of commented code. Would it be possible to clean it up?

src.ts/transaction/quai-transaction.ts Outdated Show resolved Hide resolved
src.ts/transaction/quai-transaction.ts Outdated Show resolved Hide resolved
src.ts/transaction/quai-transaction.ts Outdated Show resolved Hide resolved
src.ts/transaction/quai-transaction.ts Outdated Show resolved Hide resolved
rileystephens28
rileystephens28 reviewed May 6, 2024
View reviewed changes
src.ts/transaction/abstract-transaction.ts Show resolved Hide resolved
src.ts/transaction/abstract-transaction.ts Outdated Show resolved Hide resolved
src.ts/transaction/abstract-transaction.ts Outdated Show resolved Hide resolved
src.ts/transaction/abstract-transaction.ts Outdated Show resolved Hide resolved
src.ts/transaction/quai-transaction.ts Outdated Show resolved Hide resolved
src.ts/providers/abstract-signer.ts Outdated Show resolved Hide resolved
src.ts/providers/abstract-signer.ts Outdated Show resolved Hide resolved
src.ts/providers/abstract-provider.ts Outdated Show resolved Hide resolved
src.ts/providers/formatting.ts Outdated Show resolved Hide resolved
src.ts/providers/provider-jsonrpc.ts Outdated Show resolved Hide resolved
@rileystephens28 rileystephens28 merged commit 929e3fa into master May 7, 2024
@rileystephens28 rileystephens28 deleted the work-object-header branch June 7, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejoacosta74 alejoacosta74 alejoacosta74 left review comments

@rileystephens28 rileystephens28 rileystephens28 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robertlincecum @rileystephens28 @alejoacosta74 @Denis2626