This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Increased pool timeout to accomodate for latent connections and SIGSEGV exits properly #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gv exits properly
Djadih
reviewed
Nov 9, 2023
| unsigned poolFailoverTimeout = 0; // Return to primary pool after this number of minutes | ||
| bool reportHashrate = false; // Whether or not to report hashrate to pool | ||
| unsigned hashRateInterval = 60; // Interval in seconds among hashrate submissions | ||
| std::string hashRateId = | ||
| h256::random().hex(HexPrefix::Add); // Unique identifier for HashRate submission | ||
| unsigned connectionMaxRetries = 10; // Max number of connection retries | ||
| unsigned connectionMaxRetries = 30; // Max number of connection retries |
There was a problem hiding this comment.
The accounting for connectionMaxRetries is disabled so this is already infinite.
Djadih
reviewed
Nov 9, 2023
| cerr << "SIGSEGV encountered ...\n"; | ||
| g_running = false; | ||
| g_shouldstop.notify_all(); | ||
| break; |
There was a problem hiding this comment.
Why don't we have this code, without the break, right before the exit(128) line. There might be a reason they chose that specific exit code to display which works with other scripts.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.