Made Quai CPU Miner a CLI app #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To go with the new cli app, have added 2 flags, region and zone. Main objective of this refactor was the ease of sanity checks and inheriting all the cool features available in the cli library. Before we start integrating new proxy and other features into the Miner wanted to make the Miner a cli app.
Djadih
requested changes
Mar 1, 2023
| } | ||
| if !ctx.IsSet(ZoneFlag.Name) { | ||
| return errors.New("zone flag is not set") | ||
| } else if ctx.Int(ZoneFlag.Name) < 0 || ctx.Int(ZoneFlag.Name) > 2 { |
| // Appropriate errors | ||
| if !ctx.IsSet(RegionFlag.Name) { | ||
| return errors.New("region flag is not set") | ||
| } else if ctx.Int(RegionFlag.Name) < 0 || ctx.Int(RegionFlag.Name) > 2 { |
There was a problem hiding this comment.
Use helper common.HierarchyDepth
| if !ctx.IsSet(RegionFlag.Name) { | ||
| return errors.New("region flag is not set") | ||
| } else if ctx.Int(RegionFlag.Name) < 0 || ctx.Int(RegionFlag.Name) > 2 { | ||
| return errors.New("current ontology prime only has 3 regions, so please input between 0 and 2") |
| if !ctx.IsSet(ZoneFlag.Name) { | ||
| return errors.New("zone flag is not set") | ||
| } else if ctx.Int(ZoneFlag.Name) < 0 || ctx.Int(ZoneFlag.Name) > 2 { | ||
| return errors.New("current ontology each region only has 3 zones, so please input between 0 and 2") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To go with the new cli app, have added 2 flags, region and zone.
Main objective of this refactor was the ease of sanity checks and inheriting all the cool features available in the cli library. Before we start integrating new proxy and other features into the Miner wanted to make the Miner a cli app.
Resolves #4