Transaction hashes and failing tests #2399
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Djadih
requested review from
wizeguyy,
kiltsonfire and
gameofpointers
as code owners
Djadih
force-pushed
the
transaction-hashes
branch
4 times, most recently
from
bfc8897 to
acbbfbf
Compare
wizeguyy
approved these changes
Dec 16, 2024
Djadih
commented
Dec 16, 2024
| @@ -151,27 +184,27 @@ func (tx *Transaction) ProtoEncode() (*ProtoTransaction, error) { | |||
| // Other fields are set conditionally depending on tx type. | |||
| switch tx.Type() { | |||
| case QuaiTxType: | |||
| if tx.To() != nil { | |||
There was a problem hiding this comment.
This function was simply rearranged to match the order of elements in QuaiTx for easier verification.
Djadih
force-pushed
the
transaction-hashes
branch
from
acbbfbf to
b53b0bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.