Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics overhaul and new backend #1179

Closed
wants to merge 274 commits into from
Closed

Metrics overhaul and new backend #1179

wants to merge 274 commits into from

Conversation

Djadih
Copy link
Contributor

@Djadih Djadih commented Oct 2, 2023

Completely redoing metrics, adding new system-level ones. Internal legacy metrics will be brought back on an as-needed basis.

@Djadih Djadih self-assigned this Oct 2, 2023
@Djadih Djadih added the enhancement New feature or request label Oct 2, 2023
@Djadih Djadih added this to the GoldAge Testnet milestone Oct 2, 2023
@Djadih Djadih force-pushed the metrics branch 2 times, most recently from 8025fa8 to 8bc91fe Compare October 4, 2023 15:19
@Djadih Djadih marked this pull request as ready for review October 4, 2023 15:21
@Djadih
Copy link
Contributor Author

Djadih commented Oct 4, 2023

Screenshot_20231004_112302
Screenshot_20231004_112318

wizeguyy
wizeguyy previously approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@wizeguyy wizeguyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice to have! It might be nice to add some explanation to the readme, but no objections to the code

@Djadih
Copy link
Contributor Author

Djadih commented Oct 4, 2023

This is nice to have! It might be nice to add some explanation to the readme, but no objections to the code

Will be discussing documentation with marketing and how to link that with the readme

gameofpointers
gameofpointers requested changes Oct 5, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
wizeguyy
wizeguyy previously approved these changes Oct 12, 2023
View reviewed changes
@Djadih
Copy link
Contributor Author

Djadih commented Oct 12, 2023

Added as base command, removed an extra print, also made maxpeers work optionally rather than required

@Djadih Djadih force-pushed the metrics branch 2 times, most recently from 81edb38 to 2d1be80 Compare October 12, 2023 17:19
wizeguyy
wizeguyy reviewed Oct 12, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
wizeguyy
wizeguyy previously approved these changes Oct 12, 2023
View reviewed changes
@gameofpointers gameofpointers self-requested a review October 12, 2023 17:28
@Djadih
Copy link
Contributor Author

Djadih commented Oct 12, 2023

Slotted for v0.21

gameofpointers and others added 23 commits February 27, 2024 15:15
@gameofpointers @Djadih
bugfix: cannot get the signer for the Qi type transaction and catchin…
a56cdd6 
…g the error
@Djadih
Optimize redundant peerID creation
e42fad6
@Djadih
Modify interface to remove redundant protocol restatements
73cdd9c
@Djadih
Create new QuaiMessage type envelope for request/response
e0fa406
@Djadih
Integrate QuaiMessage in request/response handling
0e4eeb5
@Djadih
Remove read deadline due to stream reuse
83276a4
@Djadih
Make the p2p host functionality available to the peer manager
d33b818
@Djadih
Implement getrequestmanager
92bb37a
@Djadih
Implement stream cache, fix the peer pruning process
57c32e7
@kiltsonfire
Calculate Reward stub function for Qi and Quai
2610147
@jdowning100
Bugfix: Reset tx To with context in SendRawTransaction
2534ae3
@gameofpointers
Made Header Hash the hash of protobuf encoding of the header
69b83c3
@gameofpointers
Made the TX signing hash and Tx Hash a proto buf encoded hash
d9ca85f
@gameofpointers
Fixed the tests in the core/types and added a test for tx hash
87a3699
@jdowning100
Remove SuggestTipCap functionality in anticipation of QIP6
baf8195
@jdowning100
Only cache sender if tx has ECDSA signature
6bde134
@jdowning100
Bugfixes for marshalling and unmarshalling
411443f
@jdowning100
ETXs can now deploy a contract by sending to the destination contextu…
a12e6b0 
…al zero-address
@jdowning100
Added Qi UTXO-set PMT with header commitment
731e34a
@jdowning100
Renamed header state root to EVMRoot
e7e7d75
@jdowning100
Updated genesis hashes
9c67090
@jdowning100
Refactored precompile addresses to be QIP2 compatible
b93406a
@jdowning100
Bugfixes in transaction encode/decode and empty slice checks
69f4640
@Djadih Djadih force-pushed the metrics branch 3 times, most recently from db4457c to 4f6352b Compare February 29, 2024 17:21
@wizeguyy
Copy link
Member

wizeguyy commented Mar 8, 2024

no more feature PRs to main. Retarget all work to goldenage

@wizeguyy wizeguyy closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wizeguyy wizeguyy wizeguyy left review comments

@kiltsonfire kiltsonfire Awaiting requested review from kiltsonfire kiltsonfire is a code owner

@gameofpointers gameofpointers Awaiting requested review from gameofpointers gameofpointers is a code owner

Assignees

@Djadih Djadih

Labels
enhancement New feature or request
Projects
None yet
Milestone
GoldAge Testnet
Development

Successfully merging this pull request may close these issues.