bugfixes from testing #1176
Closed
bugfixes from testing #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gameofpointers
force-pushed
the
wasm
branch
4 times, most recently
from
53d039a to
2b26a98
Compare
When trying to append block, have to make sure that we have all the pre-requisite state
Thorough the testnet the downloader seems to have been blocked, so increasing this so that we don't stop the downloader completely if the doneCh is blocked
This eliminates the cost of recompute and any form of race conditions
wizeguyy
previously approved these changes
Oct 3, 2023
gameofpointers
dismissed
wizeguyy’s stale review
The merge-base changed after approval.
|
superceded by #1184 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dominant-strategies/core-dev