P2P client fixes to allow for N shard clients from a single machine #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wizeguyy
requested review from
kiltsonfire and
gameofpointers
as code owners
wizeguyy
force-pushed
the
unique-enodes
branch
from
9e57a40 to
1482bde
Compare
Djadih
previously approved these changes
Sep 25, 2023
Djadih
reviewed
Sep 26, 2023
wizeguyy
force-pushed
the
unique-enodes
branch
from
1482bde to
cd45a0e
Compare
Djadih
previously approved these changes
Sep 26, 2023
wizeguyy
force-pushed
the
unique-enodes
branch
3 times, most recently
from
db19279 to
ff95b95
Compare
kiltsonfire
previously approved these changes
Sep 27, 2023
wizeguyy
force-pushed
the
unique-enodes
branch
from
ff95b95 to
d3de029
Compare
wizeguyy
force-pushed
the
unique-enodes
branch
from
d3de029 to
1d28bc1
Compare
gameofpointers
approved these changes
Sep 28, 2023
alanorwick
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1160
Resolves #1161
tl;dr:
Previously, bootnodes would generate 13 clients with the same nodekey. This would confuse P2P routing tables. Now each client derives a unique key.
Previously Kademlia would only allow 2 peers in a bucket and 10 peers in the table from the same IP address. This quickly gets overwhelmed, since each full node runs 13 P2P clients behind the same IP address. A better long-term solution would be to proxy client connections through a single connection.