Adding lock to reduce the memory pressure while synching #1104

gameofpointers · 2023-09-12T15:50:46Z

@dominant-strategies/core-dev

Protecting the async updates

the zone UpdateDom takes zone pending header as input rather than entropy

…ith log of Difficutly (i.e bits)

consensus/blake3pow/consensus.go

consensus/blake3pow/poem.go

consensus/misc/rewards.go

consensus/progpow/consensus.go

core/block_validator.go

Djadih

One needs addressing, the rest are nice to address

GasLimit ceiling target changes based on 4 steps Each step is 150,000 blocks (i.e expected blocks for 3 weeks) GasCeil is changed to 110M because it is enough to accomodate the 1700 testnet target These changes are for the testnet and probably is not a long term controller

From simulations and rigorous testing we have understood that there is stable operating point on just using Stoichastic or using the threshold to determine Dom blocks in a Synchronous setting To be able to handle the adverse network scenarios and testnet environment and malicious miners the correct solution is mixture of having threshold to counteract malicious miners getting lucky and having a increased difficulty threshold to find a dom block

Since downloader insert is an asynchronous process, writing thousands of large blocks into the DB at the same time is very memory intensive. Adding this lock will make sure that only one block is written at a time and from the testing in the garden environment this has shown improved performance in memory use while syncing

The merge-base changed after approval.

kiltsonfire and others added 9 commits September 12, 2023 10:15

bugfix: added subReorg check on relayPh

beb5b58

bugfix: cannot have go routine on subrelay in updateDom

89ef5fd

bugfix: WriteBlock before Inserting the local mined block

1c87e99

bugfix: updated the futureblock dist from 15 to 100

56a7c94

Use bestPh to pick inslice append phHeader

923c34d

bugfix: Locking updatePhCacheFromDom and computing pending header

aabe04f

Protecting the async updates

Added location information in the Appended print

ae4e089

bugfix: UpdateDom no longer calculates, uses the pendingHeader given by

ade2813

the zone UpdateDom takes zone pending header as input rather than entropy

Modified the CalcDifficulty controller to use k factor that changes w…

0d0da91

…ith log of Difficutly (i.e bits)

gameofpointers requested review from wizeguyy and kiltsonfire as code owners September 12, 2023 15:50

wizeguyy previously approved these changes Sep 12, 2023

View reviewed changes