This repository has been archived by the owner on Mar 8, 2024. It is now read-only.
Quai client tests #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didaunesp
requested review from
wizeguyy,
kiltsonfire and
gameofpointers
as code owners
didaunesp
force-pushed
the
go-quai-libp2p
branch
from
9d3fec4 to
29dc29f
Compare
didaunesp
force-pushed
the
go-quai-libp2p
branch
7 times, most recently
from
bba3476 to
8db167d
Compare
wizeguyy
reviewed
Feb 29, 2024
| @@ -428,7 +428,8 @@ func (progpow *Progpow) verifySeal(header *types.Header) (common.Hash, error) { | |||
| if progpow.fakeFail == header.NumberU64(nodeCtx) { | |||
| return common.Hash{}, errInvalidPoW | |||
| } | |||
| return common.Hash{}, nil | |||
| //if hash is empty here, it fails because of div / 0 on poem.go: IntrinsicLogS() | |||
| return common.HexToHash("0xf5d8c9fb1a61e47c6dd4b5d0a1a0d6c0f7bce9cfae0e2a9d8a9c8d6d6f8f4f7"), nil | |||
There was a problem hiding this comment.
This is a random hash.
The hash just cant be zero because it leads to a div / 0.
didaunesp
force-pushed
the
go-quai-libp2p
branch
from
8db167d to
b76593b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.