Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/660 #776

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Issue/660 #776

wants to merge 7 commits into from

Conversation

bnordli
Copy link
Contributor

@bnordli bnordli commented Feb 15, 2017

BREAKING CHANGE (As discussed on multiple previous occasions.)

Turn assembly specification upside down: Clients must now specify which assemblies to be included, instead of which assemblies to be excluded.

PROS:

  • This simplifies assembly specification a lot (as this PR itself is an example of), since clients have much better knowledge of what should be in the application than what should not be in the application
  • Better control (avoid sudden initialization failures because of new dlls being unknowingly included)
  • In many cases better performance, since the sets of dlls included is bounded, instead of unbounded.

CONS:

  • Clients must remember to include new assemblies, but this will be discovered early.
  • It is a breaking change, after all, but should fit in the 2.0.0 milestone.

Fixes #660

@einari einari added this to the 1.2.0 milestone Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants