Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add environment variable for all flags and envvar prefix #42

Merged
merged 2 commits into from
May 27, 2024
Merged

Add environment variable for all flags and envvar prefix #42

merged 2 commits into from
May 27, 2024

Conversation

albertrdixon
Copy link
Contributor

@albertrdixon albertrdixon commented Jan 8, 2024 •
edited
Loading

What

  • Add environment variable for provider flag
  • Add environment variable for google-project flag
  • Add optional environment variables format with SECRETS_INIT prefix

Why

  • Using secrets init for apps in GCP required setting the command line flag rather than the much easier (in kubernetes at least) environment variable flow
  • Using a prefix for environment variables helps to avoid collision (in particular with LOG_FORMAT)

@sakomws
Copy link

sakomws commented Feb 5, 2024

hey, @alexei-led help is appreciated with this PR review pls.

alexei-led
alexei-led requested changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@alexei-led alexei-led left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. Please make sure all ENV variables are consistent: two ENV vars per parameter (one with prefix and another without)

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@albertrdixon albertrdixon requested a review from alexei-led May 24, 2024 19:59
@alexei-led alexei-led merged commit 32e483b into doitintl:master May 27, 2024
1 check passed
@albertrdixon albertrdixon deleted the albertrdixon/flag-env-vars branch May 28, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexei-led alexei-led alexei-led approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albertrdixon @sakomws @alexei-led