Added oaep jss test #659
Draft
Added oaep jss test #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds RSA/OAEP to jss.crypto.Algorithm as a known algorithm and adds stubs for indicating what type of key is required to use it. Signed-off-by: Alexander Scheel <[email protected]>
These tests have been updated from using DES/DES3 to AES-256. Signed-off-by: Alexander Scheel <[email protected]>
When using `-Wl,-rpath`, the final generated binaries will have a rpath include to the sandboxed libraries. This is good as it enables binaries to run from the built directory. However, at link time, we're still using the system's NSS library. This doesn't work when NSS introduces a change to its external (public) API; the system's NSS likely doesn't have this change yet. Include the `-L` flag as well, to use the sandboxed library at link time as well. Signed-off-by: Alexander Scheel <[email protected]>
While hash algorithms in JSS currently use the SEC_OID based interface (rather than PKCS#11), include them in PK11Algorithm because they have equivalent PKCS#11 constant definitions. Signed-off-by: Alexander Scheel <[email protected]>
This depends on support from NSS for two new function calls, PK11_PubWrapSymKeyWithMechanism and PK11_PubUnwrapSymKeyWithMechanism. These enable passing OAEP's mechanism parameters into NSS's high-level PK11 key wrap/unwrap interface, allowing them to succeed. Otherwise, previous versions of NSS silently converted OAEP to PKCS#1 v1.5, allowing the trivial patchset to succeed without any mechanism parameters. Introduce a JSSOAEPParameterSpec which can consume a JCA-standard OAEPParameterSpec instance but which also extends NativeEnclosure to allow us to call into the JNI layer with a parameter instance. Signed-off-by: Alexander Scheel <[email protected]>
This allows us to detect whether or not NSS supports RSA-OAEP key wrap/unwrap and if not, disable RSA-OAEP support, gracefully falling back to the old method for other mechanisms. Signed-off-by: Alexander Scheel <[email protected]>
PsOverflow
force-pushed
the
Added_OAEP_JSS_test
branch
from
2a80229 to
c6fae17
Compare
Signed-off-by: Pritam Singh <[email protected]>
PsOverflow
force-pushed
the
Added_OAEP_JSS_test
branch
from
c6fae17 to
1eff69d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.