Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

과제 완료 #8

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

suyeonii99
Copy link

과제완료했습니다.

@hyesungoh hyesungoh self-requested a review April 16, 2022 05:47
Copy link
Contributor

@hyesungoh hyesungoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰할 곳이 없이 깔끔합니당

굳이 하나 찾자면, changeBlack, changeRed와 같은 클래스명보다는 다른 명을 쓰는게 낫지 않을까? 정도예요!

근데 과제이기 때문에 편하신 방법으로 하신 것 같으니 개발할때만 명확한 이름으로 짓게 신경써주시면 좋을 거 같아요 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants