feat: support additional options for pg_dump cli

dodevops · Dec 5, 2024 · 71a6add · 71a6add
1 parent 4f90f16
commit 71a6add
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/container/backup.sh b/container/backup.sh
@@ -63,7 +63,7 @@ then
     echo "Dumping ${NAME}"
     echo "${DATABASE_HOST}:5432:${DATABASE_NAME}:${DATABASE_USERNAME}@${DATABASE_HOST}:${DATABASE_PASSWORD}" > ~/.pgpass
     chmod 0600 ~/.pgpass
-    pg_dump --format "${PG_DUMP_FORMAT}" --host="${DATABASE_HOST}" --dbname="${DATABASE_NAME}" --username="${DATABASE_USERNAME}@${DATABASE_HOST}" > dump
+    pg_dump ${PG_ADD_OPTIONS} --format "${PG_DUMP_FORMAT}" --host="${DATABASE_HOST}" --dbname="${DATABASE_NAME}" --username="${DATABASE_USERNAME}@${DATABASE_HOST}" > dump
     azcopy copy --overwrite true dump "https://${BACKUP_STORAGE_ACCOUNT}.blob.core.windows.net/${BACKUP_STORAGE_CONTAINER}/databases/${NAME}.$(date +%u).${PG_DUMP_SUFFIX}?${SAS_BACKUP}"
   done
 fi

diff --git a/helm-charts/azure-advanced-backup/templates/cronjob.yaml b/helm-charts/azure-advanced-backup/templates/cronjob.yaml
@@ -19,6 +19,8 @@ spec:
                   value: {{ .Values.config.postgres.databases }}
                 - name: PG_USE_CUSTOM_FORMAT
                   value: "{{ .Values.config.postgres.useCustomFormat }}"
+                - name: PG_ADD_OPTIONS
+                  value: "{{ .Values.config.postgres.additionalOptions }}"
                 - name: AZ_APPLICATION_ID
                   value: {{ .Values.config.auth.applicationId }}
                 - name: AZCOPY_SPA_CLIENT_SECRET

diff --git a/helm-charts/azure-advanced-backup/values.yaml b/helm-charts/azure-advanced-backup/values.yaml
@@ -29,7 +29,10 @@ config:
     # -- set to yes to use the pg_dump custom format (`--format c`) and a dmp suffix instead of the sql format and an
     #    sql suffix
     useCustomFormat: "no"
-
+    #
+    # -- optional additional pg_dump parameters, e.g. to support --no-acl --no-ower in dump which may cause problems together with the azure flexible server
+    additionalOptions: ""
+
   backupStorage:
     # -- Name of the storage account to sync the containers to
     account: ""