Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to iframe our pages #49

Merged
merged 20 commits into from
Jan 21, 2016
Merged

Add ability to iframe our pages #49

merged 20 commits into from
Jan 21, 2016

Conversation

reefdog
Copy link
Contributor

@reefdog reefdog commented Jan 21, 2016

We've accepted fixed-aspect-ratio iframe embeds (#18) and settled on an MVP for delivering them (#48). Notable changes:

  • Embed markup has been updated to more verbose 1.1
  • Resizing-observing has been limited to non-iframe context and debounced
  • Notes now try their damndest to not drip outside visible iframe bounds
  • Title and credit area persist outside of the iframe context; they are part of the external embed markup for better (easier customization) and worse (easier unintentional style poisoning)

Notable limitations:

  • Platform isn't yet ready to generate iframe embed codes; we need aspect ratios
  • No current facility for setting options
  • Menubar (if hacked to be visible) will obscure page content
  • Note design needs fixing

@reefdog
Use media queries for iframe breakpoints
d9a6c32 
Closes #47
@reefdog
Change iframe design so page image never scrolls
21be1d3
@reefdog
Added iframe example to primary page
c622150
@reefdog
Debounce all window.resize functions
1eb098e
@reefdog
Move title/credit outside of iframe
7419c79 
Big batch of changes toward #48:

- Title/credit moved outside of iframe context into static markup (which is now updated to v1.1)
- Flexbox reverted
- Note repositioning reverted (thank heavens)
- Test page enhanced with lots of examples and made wider
@reefdog
Don't let notes drip outside iframe bounds #48
f0351f1
@reefdog
Don't use DC logo image in credit area
3431161
@reefdog
Open to document when clicking tiny iframe
486734d
@reefdog
Position menubar atop page image
89ff884
@reefdog
Entirely hide meta/credit from iframed page JST
ba8fedb
@reefdog
Use ajax embedder for pixel-match example
f3aecde
@reefdog
Add 1.1/IMG embed code examples, improve columns
1bd4934
@reefdog
Add srcsets to img-based embed markup
6a64325
@reefdog
Move page embed CSS near direct embed example
f1c884d
@reefdog
Embed enhanced iframe example via Ajax
e72d241 
Keeps it consistent more easily
@reefdog
Unify page embed example markup and actual JSTs
d637354
@reefdog
Remove old iframe example page
abbf026
@reefdog
Update reference to maximum example page width
93b9479
@reefdog
Simulate embedded page template more accurately
efb6a34
@reefdog
Unify examples and actual markup
f39ba11
reefdog added a commit that referenced this pull request Jan 21, 2016
@reefdog
Merge pull request #49 from documentcloud/iframes
1f4ffec 
Add ability to iframe our pages
@reefdog reefdog merged commit 1f4ffec into master Jan 21, 2016
@reefdog reefdog deleted the iframes branch January 21, 2016 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@reefdog