Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide iframe page embeds #48

Open
4 tasks done
reefdog opened this issue Jan 15, 2016 · 0 comments
Open
4 tasks done

Provide iframe page embeds #48

reefdog opened this issue Jan 15, 2016 · 0 comments
Labels
2 - Working enhancement

Comments

@reefdog
Copy link
Contributor

reefdog commented Jan 15, 2016

The time has come. We've decided to accept a fixed-aspect-ratio page embed. We need to make a few changes to make this happen:

  • Move wrappable items (title/logo header and credit footer) out of page view so that they only exist in the embed markup
  • Make menubar minimally usable for those who hack in pageNavigator or text mode
  • Ensure notes don't pop out of page bounds
  • Serve embed pages from platform

There will be further improvements, particularly to notes, but those can come post-MVP.
@reefdog reefdog self-assigned this Jan 15, 2016
reefdog added a commit that referenced this issue Jan 20, 2016
@reefdog
Move title/credit outside of iframe
7419c79 
Big batch of changes toward #48:

- Title/credit moved outside of iframe context into static markup (which is now updated to v1.1)
- Flexbox reverted
- Note repositioning reverted (thank heavens)
- Test page enhanced with lots of examples and made wider
reefdog added a commit that referenced this issue Jan 20, 2016
@reefdog
Don't let notes drip outside iframe bounds #48
f0351f1
@reefdog reefdog mentioned this issue Jan 21, 2016
Merged
reefdog added a commit that referenced this issue Jan 21, 2016
@reefdog
Move title/credit outside of iframe
95adb70 
Big batch of changes toward #48:

- Title/credit moved outside of iframe context into static markup (which is now updated to v1.1)
- Flexbox reverted
- Note repositioning reverted (thank heavens)
- Test page enhanced with lots of examples and made wider
reefdog added a commit that referenced this issue Jan 21, 2016
@reefdog
Don't let notes drip outside iframe bounds #48
99940ed
@reefdog reefdog removed their assignment Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 - Working enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reefdog