This repository has been archived by the owner on Feb 5, 2024. It is now read-only.
[DCOM-96] proxy generation as of doctrine/common#168 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,8 +57,11 @@ public function testProxyFactorySetsProxyMetadata() | |||
| $proxy = $this->dm->getReference($this->type, 1); | |||
|
|
|||
| $proxyClass = get_class($proxy); | |||
| $this->assertTrue($this->dm->getClassMetadataFactory()->hasMetadataFor($proxyClass), "Proxy class '" . $proxyClass . "' should be registered as metadata."); | |||
There was a problem hiding this comment.
Already happens in the class metadata factory
| @@ -43,7 +43,14 @@ public function testSaveWithAssociation() | |||
| { | |||
| $article = $this->dm->find('Doctrine\Tests\Models\CMS\CmsArticle', $this->articleId); | |||
| $this->assertInstanceOf('Doctrine\Tests\Models\CMS\CmsUser', $article->user); | |||
| $this->assertNull($article->user->username, 'CmsUser is a proxy, username is NULL through public access'); | |||
| $this->assertInstanceOf('Doctrine\ODM\CouchDB\Proxy\Proxy', $article->user); | |||
There was a problem hiding this comment.
Fails also on master, no idea why
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See doctrine/common#168, doctrine/orm#406 and doctrine/mongodb-odm#445
Merging this means bumping requirement of
doctrine/commonto>=2.4.