Introduce EnvironmentAwareMigrationInterface #530
Closed
+143
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexndlm
deleted the
feature/introduce-EnvironmentAwareMigrationInterface
branch
alexndlm
restored the
feature/introduce-EnvironmentAwareMigrationInterface
branch
|
@derrabus wdyt? |
|
It seems there are CI jobs failing. Please take a look at this guide for more on how to handle those. |
|
@greg0ire, thanks, fixed. |
|
Blocked by #531 |
|
Retargeting to 3.4.x since this is no bugfix |
|
Any news on that? |
|
I'd like to close this PR. I don't think, adding more FooAwareMigrationInterfaces are the proper way forward. Instead, we should find a way to leverage DI for migrations as I layed out in #521 (comment). |
alexndlm
deleted the
feature/introduce-EnvironmentAwareMigrationInterface
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In migrations, it's best to avoid using dynamic values or services that could cause unexpected issues. However, including the current environment can be really helpful. It lets us skip migrations for testing or production and set different default values depending on the environment.