Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created an EC2 Launch Template, supporting Role and Security Group for ad-hoc maintenance of the EFS. #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

teagles
Copy link

@teagles teagles commented Dec 28, 2021

No description provided.

@doctorray117
Copy link
Owner

Hey this looks great. I'd like to test it out soon and will merge later. Do you want to draft any text for how a user might interface with the instance for file maintenance? I'm slowly but surely working through the CDK docs to be more user friendly. Thanks.

@teagles
Copy link
Author

teagles commented Jan 5, 2022

I sure can. Before I do I was tinkering with making it even more user friendly by including an ASG that defaults to 0 capacity so all the user has to do is scale that up and down to activate or deactivate an instance. Would that mode of operation be preferable to using Launch Instance with the template as I'm using it now?

@teagles
Copy link
Author

teagles commented Jan 5, 2022

Actually I just remembered why I didn't do that initially. It would require more mandatory Config to pre-seed an ssh key. I'll instead focus on an addendum to the docs that outlines the current use.

@teagles teagles force-pushed the feature/efs-maintenance branch from 627316b to 8b0cbc2 Compare January 9, 2022 21:15
@teagles
Copy link
Author

teagles commented Jan 9, 2022

Added docs with example maintenance commands.

@teagles
Copy link
Author

teagles commented Jan 18, 2022

This other pull request makes things even easier but I'll leave it up to you if you want to retain these changes for the proposed option 2.

@doctorray117
Copy link
Owner

Hi, thanks, I'll try to review these tomorrow!

@doctorray117
Copy link
Owner

I do like the ease of the ecs exec method, I want to get a better understanding on if there are limitations or issues on editing files during runtime though. If it can be done with the cloudshell then I think it's a winner. I do appreciate your work on the launch template and think it's worth including some of it for sure. Apologies for the severe delays on reviewing these, I've been a little busy with work. Thanks.

@teagles
Copy link
Author

teagles commented Jan 21, 2022

What I might do if I get time on the weekend (or later) is layering my stuff on the other change with some extra documentation and changes for the cloud shell and offline edit scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants