Coconut Proof allows empty blinding messages #21
Conversation
| let pok = MessagesPoKGenerator::init(&mut rng, &[], ¶ms, &h) | ||
| .unwrap(); | ||
|
|
||
| let mut chal_bytes_prover = vec![]; |
There was a problem hiding this comment.
As you are using the same variables for prover's and verifier's challenge, they should not have suffix _prover, chal_bytes is good.
coconut/src/proof/mod.rs
Outdated
| @@ -178,7 +178,7 @@ impl<'pair, Pair, F: PrimeField> UnpackedBlindedMessages<'pair, Pair, F> { | |||
| let (paired, (msgs, blindings)): (Vec<_>, _) = | |||
| process_results(paired, |iter| iter.unzip())?; | |||
| if paired.is_empty() { | |||
There was a problem hiding this comment.
You can remove this if block as the last else block will return the desired result.
| ); | ||
| let pok = SignaturePoKGenerator::init(&mut rng, &[], &sig, &pk, ¶ms).unwrap(); | ||
|
|
||
| let mut chal_bytes_prover = vec![]; |
There was a problem hiding this comment.
Similar comment as above on naming.
|
@lovesh Thank you so much for your quick feedbacks! I modified for all of your comments! |
|
@0xvon I have fixed the failing tests in this commit but I am not able to edit this PR even when this PR is marked appropriately. Can you please get these changes in your PR? Thanks |
I pushed! |
|
Thank you @0xvon for the contribution. |
Issue
#20
What I do