build: don't force default configuration #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bryce Lampe <[email protected]>
blampe
force-pushed
the
blampe/build-config
branch
from
f457ea2 to
6c929a4
Compare
tonistiigi
approved these changes
Jul 15, 2024
crazy-max
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RunBuildaccepts acommand.Cliinterface, but the configuration it ultimately uses for builds is always sourced fromLoadDefaultConfigFile. This makes it impossible for customCliimplementations to directly provide their own non-defaultConfigFile.This PR changes the logic to use the output of
cli.ConfigFile()instead ofLoadDefaultConfigFile. The common-caseDockerCliimplementation will continue to use the result ofLoadDefaultConfigFile(ref, ref), however it will now respect the CLI's error stream instead of forcing stderr.